Ticket #134 (closed enhancement: fixed)
Opened 20 months ago
Last modified 20 months ago
/etc/init.d/fsck should check boot_parameter only for start not for stop
| Reported by: | vaeth@mathematik.uni-wuerzburg.de | Owned by: | roy |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | init.d scripts | Version: | 0.4 |
| Keywords: | Cc: |
Description
The boot_parameter forcefsck which forces a filesystemcheck on startup is very convenient if there were problems during the previous shutdown. However, if fsck_shutdown="YES" is set in /etc/conf.d/fsck, there is no way to shut down the system cleanly without a second filesystem check (or without manually editing this file and restoring it after the next startup).
IMHO, it would be more reasonable if the boot_parameter forcefsck is checked only in the start phase and not in the stop phase of /etc/init.d/fsck
Change History
comment:1 Changed 20 months ago by roy
comment:2 Changed 20 months ago by Matthias Schwarzott <zzam@gentoo.org>
Maybe /forcefsck file should also be handled different at shutdown.
Either this means: check after next reboot, or check at this shutdown, but then it needs to be removed to prevent checking at next boot too.
I vote for answer A. Apply /forcefsck only at boot, else root filesystem will not be checked as it is still RW at shutdown time.
comment:3 Changed 20 months ago by roy
- Status changed from new to closed
- Resolution set to fixed
Sounds good in r1462 :)
comment:4 Changed 20 months ago by Matthias Schwarzott <zzam@gentoo.org>
- Status changed from closed to reopened
- Resolution fixed deleted
There is a typo in your fix.
_forcefsck { return 1; }
This misses "()" after the name.
Can't argue with that. Fixed in r1461.