Ticket #77 (closed defect: fixed)
Opened 2 years ago
Last modified 2 years ago
multiplex fsck doesn't work with reiserfs
Reported by: | Nahor <nahor.j+openrc@gmail.com> | Owned by: | roy |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | rc | Version: | |
Keywords: | Cc: |
Description
I uncommented the line "fsck_passno="=1 =2"" in /etc/conf.d/fsck
When the system boots, I get an error:
fsck | * Checking local filesystems [passno =1 =2] ... [ ok ]
fsck |Usage: fsck.reiserfs [mode] [options] device
fsck |
fsck |Modes:
fsck | --check consistency checking (default)
[...]
Maybe it's because it's the mountpoint that is passed to fsck.reiserfs instead of the device?
Attachments
Change History
comment:328 Changed 2 years ago by Nahor <nahor.j+openrc@gmail.com>
- Priority changed from enhancement to normal
comment:331 Changed 2 years ago by roy
resierfs seems to have it's own special meaning for the -p flag which we use by default. Other fs's use it as "preen" mode. Try disabling it by setting fsck_args= in the conf file.
If that fails, attach the output of
/etc/init.d/fsck --debug zap start
Changed 2 years ago by Nahor <nahor.j+openrc@gmail.com>
- attachment bug77.txt added
Log from the broken run
comment:343 Changed 2 years ago by Nahor <nahor.j+openrc@gmail.com>
Created an attachment (id=27)
Log from the broken run
Nope, that was not it. But I did find the bug.
As indicated above, my fsck_passno is "=1 =2". However, I don't have any mount with a passno equals to 2. I put it as a "reserved passno" for later use.
Since I don't have any mount, fstabinfo returns an empty list when checking "=2". That empty list is still added to fsck's arguments:
fsck -p -C0 -T /
fsck.reiserfs doesn't like that empty string at the end. Once I removed the "=2" in fsck_passno, it worked fine (fsck -p -C0 -T /)
comment:344 Changed 2 years ago by roy
Created an attachment (id=28)
Don't quote fstabinfo
Try this patch :)
comment:362 Changed 2 years ago by Nahor <nahor.j+openrc@gmail.com>
That works. Thanks.
comment:365 Changed 2 years ago by roy
- Status changed from new to resolved
- Resolution set to fixed
Fixed in git.
addendum: even with a device path it fails.