Ticket #177 (closed defect: fixed)

Opened 14 months ago

Last modified 14 months ago

OpenRC-0.5.0 doesn't build with Linux 2.6.30 headers

Reported by: xtraeme@gmail.com Owned by: roy
Priority: major Milestone:
Component: rc Version: 0.5
Keywords: Cc:

Description

I've been trying to update OpenRC to the latest stable version, 0.5.0 but the build failed in src/rc/rc.c because COMMAND_LINE_SIZE is undefined with the headers installed by the Linux kernel 2.6.30.

What happens is that in 2.6.30, <asm/setup.h> has COMMAND_LINE_SIZE in a KERNEL ifdef block, and then the unifdef program removes completely this block
when the headers are installed.

So AFAIK, you aren't suppossed to use this definition from userspace programs.

Attachments

build.diff Download (347 bytes) - added by xtraeme@gmail.com 14 months ago.
Patch to workaround build failure

Change History

Changed 14 months ago by xtraeme@gmail.com

Patch to workaround build failure

comment:1 Changed 14 months ago by roy

  • Status changed from new to closed
  • Resolution set to fixed

Thanks for the patch, but we shouldn't be doing that as kernel size may change.
A much better approach is to use rc_getline (small version of glibc getline) so we have a dynamic buffer :)

Fixed in 6abeec74301d8406ebbbd653b9fe9a0e234c09bf

Note: See TracTickets for help on using tickets.